bhavnish.arora/assignment-4
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

dev #1

Merged
rishabh merged 7 commits from dev into main 2025-01-02 12:46:37 +00:00
Conversation 0 Commits 7 Files changed 20 +6474
bhavnish.arora commented 2025-01-02 05:08:39 +00:00
Owner
Copy link
No description provided.
bhavnish.arora added 5 commits 2025-01-02 05:08:40 +00:00
bhavnish.arora requested review from rishabh 2025-01-02 05:08:46 +00:00
bhavnish.arora added 1 commit 2025-01-02 05:36:29 +00:00
rishabh approved these changes 2025-01-02 07:48:23 +00:00
src/components/characterDetail/CharacterDetails.jsx Outdated
@ -0,0 +19,4 @@
})
.catch((err) => {
console.log(err);
});
rishabh commented 2025-01-02 07:48:20 +00:00
Collaborator
Copy link

Add .finally statement for stop the loading

Add .finally statement for stop the loading
src/components/characterDetail/CharacterDetails.jsx Outdated
@ -0,0 +20,4 @@
.catch((err) => {
console.log(err);
});
}, []);
rishabh commented 2025-01-02 07:47:08 +00:00
Collaborator
Copy link

id need to be in dependancy array

id need to be in dependancy array
bhavnish.arora added 1 commit 2025-01-02 10:51:57 +00:00
rishabh merged commit 504e335da7 into main 2025-01-02 12:46:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
rishabh
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: bhavnish.arora/assignment-4#1
No description provided.
Delete branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?