Sumit Kumar sumitdml123
0 followers · 0 following
  • Joined on 2024-06-12
Repositories Projects Packages Public activity Starred repositories
sumitdml123 commented on pull request eknoor547/Assignment_4#1 2025-01-03 10:00:40 +00:00
Latest Changes
  • The static value '4' used as a fallback for recipe?.servings is incorrect. Consider providing a more dynamic or meaningful default value.
sumitdml123 suggested changes for eknoor547/Assignment_4#1 2025-01-03 10:00:40 +00:00
Latest Changes
sumitdml123 pushed to main at veerjot_dml/assignment4_api 2025-01-03 05:38:58 +00:00
36e1696938 Merge pull request 'dev' (#1) from dev into main
40170f19ce update review changes
7d83e8cab9 add-filter-data
4a1b27f9c7 update code
213e225797 task4 code
Compare 5 commits »
sumitdml123 merged pull request veerjot_dml/assignment4_api#1 2025-01-03 05:38:57 +00:00
dev
sumitdml123 approved veerjot_dml/assignment4_api#1 2025-01-03 05:38:53 +00:00
dev
sumitdml123 commented on pull request eknoor547/Assignment_4#1 2025-01-02 12:53:13 +00:00
Latest Changes

Not using Optional chaining on front-end to access the object properties if the data is coming from back-end. This will lead to crash in application if some does not exist in an object. …

sumitdml123 commented on pull request veerjot_dml/assignment4_api#1 2025-01-02 12:23:12 +00:00
dev

better use more secure way to store the keys create one env file to store these keys and access them from there

sumitdml123 commented on pull request veerjot_dml/assignment4_api#1 2025-01-02 12:23:12 +00:00
dev

same here as well

sumitdml123 commented on pull request veerjot_dml/assignment4_api#1 2025-01-02 12:23:12 +00:00
dev

use optional chaining here use cat?.id instead of cat.id

sumitdml123 commented on pull request veerjot_dml/assignment4_api#1 2025-01-02 12:23:12 +00:00
dev

use optional chaining here as well

sumitdml123 commented on pull request veerjot_dml/assignment4_api#1 2025-01-02 12:23:12 +00:00
dev

use optional chaining here

sumitdml123 commented on pull request veerjot_dml/assignment4_api#1 2025-01-02 12:23:12 +00:00
dev

whenever use navigation start using optional chaining that will reduce the chance of breakage

sumitdml123 suggested changes for veerjot_dml/assignment4_api#1 2025-01-02 12:23:12 +00:00
dev
sumitdml123 commented on pull request jaanvi/Swiper-Sliders#1 2025-01-02 11:08:35 +00:00
Code Review For Assignment-3

unused div

sumitdml123 commented on pull request jaanvi/Swiper-Sliders#1 2025-01-02 11:08:35 +00:00
Code Review For Assignment-3

extra

sumitdml123 commented on pull request jaanvi/Swiper-Sliders#1 2025-01-02 11:08:35 +00:00
Code Review For Assignment-3

The alt text for images could be more descriptive to enhance SEO and accessibility further (e.g., instead of "Evil," write "Evil Genius Games").

sumitdml123 approved jaanvi/Swiper-Sliders#1 2025-01-02 11:08:35 +00:00
Code Review For Assignment-3
sumitdml123 pushed to main at veerjot_dml/swipe_slider 2025-01-02 10:00:52 +00:00
cd7a811b88 Merge pull request 'task 3 code' (#1) from dev into main
ca1a1bff4a task 3 code
Compare 2 commits »
sumitdml123 merged pull request veerjot_dml/swipe_slider#1 2025-01-02 10:00:51 +00:00
task 3 code
sumitdml123 pushed to main at jaanvi/Multi-Step-Form_Task2 2025-01-02 09:56:19 +00:00
34c7dc488b Merge pull request 'review assignment2' (#3) from develop into main
dbccfebb5a Update style.css
68cf15aca6 Update script.js
5da495e0e8 Update index.html
d1e7c65920 Update style.css
Compare 9 commits »