review Assignment-4 #1

Open
jaanvi wants to merge 0 commits from dev into main
Owner
No description provided.
jaanvi added 2 commits 2025-01-03 04:47:12 +00:00
jaanvi requested review from sumitdml123 2025-01-03 04:48:18 +00:00
jaanvi requested review from mayank.sethi 2025-01-03 04:48:18 +00:00
sumitdml123 requested changes 2025-01-03 11:55:22 +00:00
movie-app/.env Outdated
@ -0,0 +1 @@
REACT_APP_ACCESS_TOKEN = eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiI1OTY5MGVmZDE0ZTM3NTIyNWM0NTMxZmNkY2VkMjkwMSIsIm5iZiI6MTczNTU1OTMwMS41NDksInN1YiI6IjY3NzI4ODg1OThmMmY4MmZjNDkyNmY3ZSIsInNjb3BlcyI6WyJhcGlfcmVhZCJdLCJ2ZXJzaW9uIjoxfQ.UzaJvuxHsMibgfMtuRWROSX2uGrNNP59LWap2ghYNUQ
Collaborator

why uploading secure keys on server this will make your website easily hackable

why uploading secure keys on server this will make your website easily hackable
@ -0,0 +3,4 @@
function App() {
return (
<>
Collaborator

don't use fragment

don't use fragment
@ -0,0 +20,4 @@
align-items: center;
height: 100vh;
padding: 20px;
overflow: hidden;
Collaborator

overflow: hidden;

overflow: hidden;
@ -0,0 +27,4 @@
`https://api.themoviedb.org/3/movie/${movieId}/videos?api_key=59690efd14e375225c4531fcdced2901`
);
const videoData = await videoResponse.json();
const trailer = videoData.results.find(
Collaborator

optional chaining

optional chaining
@ -0,0 +58,4 @@
<div className="movie-detail-container">
<div className="movie-detail-card">
<img
src={`https://image.tmdb.org/t/p/w500/${movieDetails.poster_path}`}
Collaborator

optional chaining

optional chaining
@ -0,0 +65,4 @@
<div className="movie-detail-info">
<h2>{movieDetails.title}</h2>
<p className="movie-detail-release-date">
<strong>Release Date:</strong> {movieDetails.release_date}
Collaborator

optional chaining

optional chaining
@ -0,0 +76,4 @@
{movieDetails.genres.map((genre) => genre.name).join(", ")}
</p>
<p className="movie-detail-runtime">
<strong>Runtime:</strong> {movieDetails.runtime} minutes
Collaborator

optional chaining

optional chaining
@ -0,0 +108,4 @@
}
if (searchResults.length > 0) {
Collaborator

searchResults.length - add option option chain

searchResults.length - add option option chain
@ -0,0 +121,4 @@
>
<img
src={`https://image.tmdb.org/t/p/w500/${movie.poster_path}`}
alt={movie.title}
Collaborator

optional chaining

optional chaining
@ -0,0 +1,64 @@
// import React, { useState, useEffect } from "react";
Collaborator

unused file remove it

unused file remove it
@ -0,0 +20,4 @@
`https://api.themoviedb.org/3/search/movie?api_key=59690efd14e375225c4531fcdced2901&query=${searchTerm}`
);
const data = await response.json();
setSuggestions(data.results);
Collaborator

optional chaining

optional chaining
@ -0,0 +40,4 @@
return (
<>
<div>
Collaborator

don't use extra div

don't use extra div
@ -0,0 +47,4 @@
<img src={logo} alt="logo" className="logo" />
</div>
<div className="filters">
Collaborator

Extra classes in Header: Review and remove any unnecessary CSS classes to simplify the component and improve performance.

Extra classes in Header: Review and remove any unnecessary CSS classes to simplify the component and improve performance.
@ -0,0 +77,4 @@
step="0.1"
value={rating[0]}
onChange={(e) =>
setRating([parseFloat(e.target.value), rating[1]])
Collaborator

why using static index rating[1]

why using static index rating[1]
@ -0,0 +100,4 @@
<li
key={movie.id}
className="suggestion-item"
onClick={() => handleSuggestionClick(movie.id)}
Collaborator

optional chaining is missing

optional chaining is missing
@ -0,0 +35,4 @@
};
return (
<><div className="movie-container">
Collaborator

Don't use fragment

Don't use fragment
@ -0,0 +40,4 @@
<div key={movie.id} className="movie-card">
<img
className="movie-poster"
src={`https://image.tmdb.org/t/p/w500${movie.poster_path}`}
Collaborator

optional chaining

optional chaining
@ -0,0 +42,4 @@
className="movie-poster"
src={`https://image.tmdb.org/t/p/w500${movie.poster_path}`}
alt={movie.title} />
<div className="movie-details">
Collaborator

Extra classes in Movie: Review and remove any unnecessary CSS classes to simplify the component and improve performance

Extra classes in Movie: Review and remove any unnecessary CSS classes to simplify the component and improve performance
@ -0,0 +44,4 @@
alt={movie.title} />
<div className="movie-details">
<h3 className="movie-title">{movie.title}</h3>
<p className="movie-overview">{movie.overview}</p>
Collaborator

optional chaining

optional chaining
@ -0,0 +1,5 @@
// jest-dom adds custom jest matchers for asserting on DOM nodes.
Collaborator

remove commented code

remove commented code
jaanvi force-pushed dev from 92ccb90a54 to 5dae8ce6c0 2025-01-03 21:04:49 +00:00 Compare
jaanvi added 1 commit 2025-01-03 21:17:49 +00:00
jaanvi added 1 commit 2025-01-03 21:18:40 +00:00
jaanvi requested review from sumitdml123 2025-01-06 04:30:51 +00:00
jaanvi added 1 commit 2025-01-15 04:30:54 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dev:dev
git checkout dev

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff dev
git checkout main
git merge --ff-only dev
git checkout dev
git rebase main
git checkout main
git merge --no-ff dev
git checkout main
git merge --squash dev
git checkout main
git merge --ff-only dev
git checkout main
git merge dev
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jaanvi/Movie-App#1
No description provided.