jaanvi/Multi-Step-Form_Task2
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Form Interface and Basic Validations #1

Closed
jaanvi wants to merge 0 commits from develop into main
pull from: develop
merge into: jaanvi:main
Conversation 0 Commits - Files changed - +355
jaanvi commented 2024-12-26 09:23:15 +00:00
Owner
Copy link
No description provided.
jaanvi added 1 commit 2024-12-26 09:23:16 +00:00
jaanvi requested review from sumitdml123 2024-12-26 09:24:09 +00:00
jaanvi requested review from mayank.sethi 2024-12-26 09:24:10 +00:00
jaanvi added 1 commit 2024-12-26 09:25:19 +00:00
jaanvi changed title from first commit to Form Interface and Basic Validations 2024-12-26 09:28:40 +00:00
sumitdml123 approved these changes 2024-12-26 11:19:17 +00:00
index.html Outdated
@ -0,0 +11,4 @@
<div class="container">
<form id="form1" >
<h3>PERSONAL DETAILS</h3>
<input type="text" id="full name" placeholder="Full Name" required>
sumitdml123 commented 2024-12-26 11:13:45 +00:00
Collaborator
Copy link
  • there should be no space in id "full name"
  • use fullname instead of full name
- there should be no space in id "full name" - use fullname instead of full name
index.html Outdated
@ -0,0 +17,4 @@
<span class="error-message" id="email-error"></span>
<input type="tel" id="phone" placeholder="Phone No" required pattern="\d{10}">
<span class="error-message" id="phone-error"></span>
<input type="number" placeholder="Age" name="age" min="18" max="100">
sumitdml123 commented 2024-12-26 11:14:16 +00:00
Collaborator
Copy link

validation is missing from age

validation is missing from age
index.html Outdated
@ -0,0 +21,4 @@
<span class="error-message" id="age-error"></span>
<label >Gender</label>
<label class="radio-inline">
sumitdml123 commented 2024-12-26 11:12:37 +00:00
Collaborator
Copy link
  • add value as male, female and other
  • name should be gender
- add value as male, female and other - name should be gender
script.js Outdated
@ -0,0 +16,4 @@
//Display Review Section
Next1.onclick=function(){
form1.style.left = "-450px";
sumitdml123 commented 2024-12-26 11:16:48 +00:00
Collaborator
Copy link

The left property is replaced with transform, which is more appropriate for handling animations and transitions, and it avoids layout reflows.

example translateX(-450px)

The left property is replaced with transform, which is more appropriate for handling animations and transitions, and it avoids layout reflows. example translateX(-450px)
jaanvi commented 2024-12-26 12:55:52 +00:00
Author
Owner
Copy link

done

done
style.css Outdated
@ -0,0 +127,4 @@
.dropdown select{
position:relative;
min-width: 18px;
sumitdml123 commented 2024-12-26 11:18:58 +00:00
Collaborator
Copy link

min-width check does 18 px works for it or not?
if not it should be approx 180 px

min-width check does 18 px works for it or not? if not it should be approx 180 px
jaanvi commented 2024-12-26 12:55:43 +00:00
Author
Owner
Copy link

done

done
jaanvi added 1 commit 2024-12-26 12:56:47 +00:00
jaanvi added 1 commit 2024-12-26 12:57:40 +00:00
jaanvi added 1 commit 2024-12-26 12:58:11 +00:00
jaanvi closed this pull request 2024-12-26 12:58:43 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
mayank.sethi
sumitdml123
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jaanvi/Multi-Step-Form_Task2#1
No description provided.
Delete branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?