jaanvi/bulk-email
1
0
Fork 0
Code Issues Pull requests 1 Actions Packages Projects Releases Wiki Activity

dev-jaanvi #1

Open
jaanvi wants to merge 155 commits from dev-jaanvi into main
pull from: dev-jaanvi
merge into: jaanvi:main
Conversation 1 Commits 155 Files changed 39 +38885 -1
jaanvi commented 2025-05-30 11:11:43 +00:00
Owner
Copy link
No description provided.
jaanvi added 152 commits 2025-05-30 11:11:44 +00:00 
Reviewed-on: DigiMantra/digiev_frontend#1
Reviewed-on: DigiMantra/digiev_frontend#2
Reviewed-on: DigiMantra/digiev_frontend#3
Reviewed-on: DigiMantra/digiev_frontend#4
Reviewed-on: DigiMantra/digiev_frontend#7
Reviewed-on: DigiMantra/digiev_frontend#6
Reviewed-on: DigiMantra/digiev_frontend#5
Reviewed-on: DigiMantra/digiev_frontend#8
Reviewed-on: DigiMantra/digiev_frontend#9
Reviewed-on: DigiMantra/digiev_frontend#11
Reviewed-on: DigiMantra/digiev_frontend#12
Reviewed-on: DigiMantra/digiev_frontend#13
Reviewed-on: DigiMantra/digiev_frontend#14
Reviewed-on: DigiMantra/digiev_frontend#16
Reviewed-on: DigiMantra/digiev_frontend#17
Reviewed-on: DigiMantra/digiev_frontend#20
Reviewed-on: DigiMantra/digiev_frontend#18
Reviewed-on: DigiMantra/digiev_frontend#21
Reviewed-on: DigiMantra/digiev_frontend#22
Reviewed-on: DigiMantra/digiev_frontend#23
Reviewed-on: DigiMantra/digiev_frontend#24
Reviewed-on: DigiMantra/digiev_frontend#25
Reviewed-on: DigiMantra/digiev_frontend#26
Reviewed-on: DigiMantra/digiev_frontend#27
Reviewed-on: DigiMantra/digiev_frontend#28
Reviewed-on: DigiMantra/digiev_frontend#29
Reviewed-on: DigiMantra/digiev_frontend#30
Reviewed-on: DigiMantra/digiev_frontend#31
VishalMaurya reviewed 2025-06-02 07:18:23 +00:00
src/pages/NotFoundPage/index.tsx
@ -0,0 +6,4 @@
// Animation for the car icon
const pulse = keyframes`
0% {
transform: scale(1);
VishalMaurya commented 2025-06-02 07:18:23 +00:00
First-time contributor
Copy link

put it in the css file

put it in the css file
jaanvi marked this conversation as resolved
VishalMaurya reviewed 2025-06-02 07:18:58 +00:00
src/pages/EmailPage/index.tsx
@ -0,0 +34,4 @@
"Sending email to:",
selectedStudents.map((s) => s.email)
);
console.log("Subject:", subject);
VishalMaurya commented 2025-06-02 07:18:58 +00:00
First-time contributor
Copy link

Remove all console logs

Remove all console logs
jaanvi marked this conversation as resolved
VishalMaurya reviewed 2025-06-02 07:24:14 +00:00
src/components/CustomTable/customTable.tsx Outdated
@ -0,0 +22,4 @@
const StyledTableCell = styled(TableCell)(({ theme }) => ({
[`&.${tableCellClasses.head}`]: {
backgroundColor: "#000000",
color: "#D0E1E9",
VishalMaurya commented 2025-06-02 07:24:14 +00:00
First-time contributor
Copy link

Don't use the hardcoded color codes

Don't use the hardcoded color codes
jaanvi marked this conversation as resolved
VishalMaurya reviewed 2025-06-02 07:27:42 +00:00
src/redux/slices/backlogSlice.ts Outdated
@ -0,0 +76,4 @@
state.students = state.students.filter(
(student) => student.id !== action.payload
);
toast.success("Student removed from local backlog.");
VishalMaurya commented 2025-06-02 07:27:42 +00:00
First-time contributor
Copy link

Its better to keep the messages in separate constant file for use.

Its better to keep the messages in separate constant file for use.
jaanvi marked this conversation as resolved
VishalMaurya commented 2025-06-02 07:31:53 +00:00
First-time contributor
Copy link
  1. Remove all react logos
  2. js and tsx both files used with same logic
1. Remove all react logos 2. js and tsx both files used with same logic
VishalMaurya reviewed 2025-06-02 07:43:50 +00:00
src/hooks/useAuth.js Outdated
@ -0,0 +12,4 @@
React.useEffect(() => {
if (isAuthenticated) {
dispatch(checkUserAuth());
VishalMaurya commented 2025-06-02 07:43:50 +00:00
First-time contributor
Copy link

If its authenticated then why again checking checkUserAuth.

If its authenticated then why again checking checkUserAuth.
jaanvi marked this conversation as resolved
arshdeep-dml reviewed 2025-06-02 09:19:29 +00:00
public/index.html Outdated
@ -0,0 +12,4 @@
<meta name="theme-color" content="#000000" />
<meta
name="description"
content="Web site created using create-react-app"
arshdeep-dml commented 2025-06-02 09:19:29 +00:00
First-time contributor
Copy link

add app specific meta description.

add app specific meta description.
jaanvi marked this conversation as resolved
arshdeep-dml reviewed 2025-06-02 09:22:23 +00:00
public/manifest.json Outdated
@ -0,0 +1,25 @@
{
"short_name": "React App",
"name": "Create React App Sample",
arshdeep-dml commented 2025-06-02 09:22:23 +00:00
First-time contributor
Copy link

Add app-specific values for the short_name and name fields.

Add app-specific values for the short_name and name fields.
jaanvi marked this conversation as resolved
arshdeep-dml reviewed 2025-06-02 09:50:36 +00:00
src/components/CustomTable/customTable.tsx Outdated
@ -0,0 +21,4 @@
// Styled Components
const StyledTableCell = styled(TableCell)(({ theme }) => ({
[`&.${tableCellClasses.head}`]: {
backgroundColor: "#000000",
arshdeep-dml commented 2025-06-02 09:50:36 +00:00
First-time contributor
Copy link

Color codes are already defined in the theme; use theme values instead of hardcoded colors.
Theme file path src/shared-theme/AppTheme.tsx

Color codes are already defined in the theme; use theme values instead of hardcoded colors. Theme file path src/shared-theme/AppTheme.tsx
jaanvi marked this conversation as resolved
jaanvi added 3 commits 2025-06-02 10:08:03 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dev-jaanvi:dev-jaanvi
git checkout dev-jaanvi

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff dev-jaanvi
git checkout main
git merge --ff-only dev-jaanvi
git checkout dev-jaanvi
git rebase main
git checkout main
git merge --no-ff dev-jaanvi
git checkout main
git merge --squash dev-jaanvi
git checkout main
git merge --ff-only dev-jaanvi
git checkout main
git merge dev-jaanvi
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jaanvi/bulk-email#1
No description provided.
Delete branch "dev-jaanvi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?