Sumit Kumar sumitdml123
  • Joined on 2024-06-12
sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

naming convention is not right use proper variable names

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

You're using const [setUserDetail] = useState(null);, but setUserDetail is not required as a state. Instead, you can directly navigate with the user details using state in useNavigate.

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

error handling is missing from the function use try catch

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

toLocaleDateString('en-US') use this

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

toLocaleDateString('en-US') use like this

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 commented on pull request mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First

optional chaining is missing

sumitdml123 suggested changes for mihir_dml/Assigment4#1 2025-01-03 12:26:21 +00:00
First
sumitdml123 merged pull request jaanvi/Swiper-Sliders#1 2025-01-03 11:56:48 +00:00
Code Review For Assignment-3
sumitdml123 pushed to master at jaanvi/Swiper-Sliders 2025-01-03 11:56:48 +00:00
2c5517e463 Merge pull request 'Code Review For Assignment-3' (#1) from dev into master
57f0dbfc7e Update Assignment-3 1/Assignment-3/index.html
f849493b69 Update Assignment-3 1/Assignment-3/index.html
454f381318 Update Assignment-3 1/Assignment-3/index.html
3725140ae5 Update Assignment-3 1/Assignment-3/index.html
Compare 9 commits »
sumitdml123 commented on pull request jaanvi/Movie-App#1 2025-01-03 11:55:23 +00:00
review Assignment-4

unused file remove it