assignment5 Blogpost code review #1

Merged
sumitdml123 merged 6 commits from dev into main 2025-01-14 11:35:16 +00:00
Owner
No description provided.
veerjot_dml added 2 commits 2025-01-07 05:58:04 +00:00
veerjot_dml requested review from sumitdml123 2025-01-07 05:58:09 +00:00
veerjot_dml added 1 commit 2025-01-07 06:31:14 +00:00
veerjot_dml added 1 commit 2025-01-07 06:47:54 +00:00
veerjot_dml reviewed 2025-01-08 05:23:51 +00:00
src/App.css Outdated
@ -0,0 +1 @@
Author
Owner

remove file

remove file
veerjot_dml reviewed 2025-01-08 05:25:50 +00:00
@ -0,0 +28,4 @@
return (
<div className="App">
<ul>
Author
Owner

run prettier on whole code

run prettier on whole code
veerjot_dml marked this conversation as resolved
veerjot_dml reviewed 2025-01-08 05:28:24 +00:00
src/env.js Outdated
@ -0,0 +1 @@
export const api_url = "https://jsonplaceholder.typicode.com/posts";
Author
Owner

do not push env file

do not push env file
veerjot_dml marked this conversation as resolved
veerjot_dml reviewed 2025-01-08 05:29:54 +00:00
@ -0,0 +2,4 @@
import Body from "./Body";
import SearchBar from "./SearchBar";
import "../styleing/layout.css";
import { api_url } from "../env";
Author
Owner

wrong way of importing env fix this

wrong way of importing env fix this
veerjot_dml marked this conversation as resolved
veerjot_dml reviewed 2025-01-08 05:30:48 +00:00
@ -0,0 +9,4 @@
const [filteredData, setFilteredData] = useState([]);
const [currentPage, setCurrentPage] = useState(1);
const fetchData = async () => {
Author
Owner

refactor code and make reusable function /hook

refactor code and make reusable function /hook
veerjot_dml marked this conversation as resolved
veerjot_dml reviewed 2025-01-08 05:31:29 +00:00
@ -0,0 +25,4 @@
if (!searchTerm) {
setFilteredData(data);
} else {
const filtered = data.filter(
Author
Owner

add opting chaining

add opting chaining
veerjot_dml marked this conversation as resolved
veerjot_dml reviewed 2025-01-08 05:32:05 +00:00
@ -0,0 +27,4 @@
} else {
const filtered = data.filter(
(post) =>
post?.title.toLowerCase().includes(searchTerm?.toLowerCase()) ||
Author
Owner

add optional chaining .

add optional chaining .
veerjot_dml marked this conversation as resolved
veerjot_dml reviewed 2025-01-08 05:33:16 +00:00
@ -0,0 +31,4 @@
post?.body.toLowerCase().includes(searchTerm?.toLowerCase())
);
if(filtered.length>0){
setFilteredData([filtered[0]]);
Author
Owner

fix this

fix this
veerjot_dml marked this conversation as resolved
veerjot_dml reviewed 2025-01-08 05:37:15 +00:00
@ -0,0 +12,4 @@
width: 300px;
border: 1px solid #ccc;
border-radius: 4px;
background-color: #f9f9f9;
Author
Owner

user css variables

user css variables
veerjot_dml marked this conversation as resolved
veerjot_dml reviewed 2025-01-08 05:41:15 +00:00
@ -0,0 +30,4 @@
<ul>
{filteredData.length > 0 ? (
currentPosts.map((post) => (
Author
Owner

optional chaning

optional chaning
veerjot_dml marked this conversation as resolved
veerjot_dml added 1 commit 2025-01-08 11:53:52 +00:00
veerjot_dml changed title from dev to assignment5 Blogpost code review 2025-01-09 06:10:11 +00:00
veerjot_dml added 1 commit 2025-01-09 06:12:38 +00:00
veerjot_dml requested review from rohanrana 2025-01-09 12:53:13 +00:00
sumitdml123 merged commit e3abce1e1a into main 2025-01-14 11:35:16 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: veerjot_dml/BlogPost#1
No description provided.